-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show quick actions on narrow screens #4580
Conversation
00159b6
to
d54935b
Compare
bf559fb
to
51c15a1
Compare
{selectedAssets.length === 1 && ( | ||
<div className={styles.quickActions}> | ||
<div className={styles.actions}> | ||
<ProjectQuickActions asset={selectedAssets[0]} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder… when I select a project, and do some bulk action (e.g. archive) and it goes through successfuly, the projects list updated, but the project is still selected. Do you think we should unselect all projects whenever the list is being updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's more normal to retain the selection after a bulk action. e.g. Gmail bulk "mark read", Finder bulk rename or tag – both retain the selection.
More:
- For us it's a little moot right now since we only support delete. But if we supported >1 archive it might be nice to retain the selection so you can see where they all went.
- I definitely want to retain the selection if the list is 'updated' due to
paginationinfinite scroll
This selection UI in general feels a little incomplete, as we don't support ranged selection or deselect-all (clear selection button) yet. If we add bulk archive / unarchive it would be nice to have an undo. And it might be nice to have a "X projects selected" indicator somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel it would be nice to have it (not saying we should add it right now), as after I archived a project, it went outside the visible area. By mistake user could think that there is nothing selected, and could select another project and got confused or did some action unknowingly.
Use 'Delete 1 project' for consistency with bulk delete
51c15a1
to
15907ef
Compare
15907ef
to
67cf25f
Compare
Description
Wrap the Projects View header so that quick action buttons show up on mobile devices.
Reduce quick actions to Sharing, Archive, Delete.
Show the buttons even if the selection is empty, and show helpful tooltips on desktop even when actions are not possible.
Related issues
Fixes #4583
Related to #4404
Details
These are the Quick Actions now:
The 'Edit Project' button and the dropdown menu with other actions were removed.
Placeholder buttons for Archive, Sharing, Delete are now shown all the time.
Bulk 'Delete' button is now enabled only if the user has management access to every selected project.
Checklist